Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #551

Merged
merged 15 commits into from
Aug 18, 2023
Merged

Master #551

merged 15 commits into from
Aug 18, 2023

Conversation

abhishek9686
Copy link
Member

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 4 committers have signed the CLA.

✅ mattkasun
✅ abhishek9686
❌ Gravitl
❌ github-actions[bot]

Gravitl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@abhishek9686 abhishek9686 merged commit 7451c15 into develop Aug 18, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@theguy951357 theguy951357 theguy951357 approved these changes

@Aceix Aceix Awaiting requested review from Aceix

@gabrielseibel1 gabrielseibel1 Awaiting requested review from gabrielseibel1

@afeiszli afeiszli Awaiting requested review from afeiszli

@uGiFarukh uGiFarukh Awaiting requested review from uGiFarukh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishek9686 @CLAassistant @theguy951357 @mattkasun